Allon Mureinik has posted comments on this change.
Change subject: core: fixing pom to include apache commons-lang.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Not that I have anything against commons-lang, but adding it for a single
usecase, that can be easily handled by java seems redundant, IMHO.
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/PoolConditionFieldAutoCompleter.java
Line 33:
Line 34: @Override
Line 35: public IConditionValueAutoCompleter
getFieldValueAutoCompleter(String fieldName) {
Line 36: IConditionValueAutoCompleter retval = null;
Line 37: if (StringUtils.equals(fieldName, "TYPE")) {
Using StringUtils here looks like overkill - since you're comparing to a
constant, just use "TYPE".equals(fieldName)
Line 38: retval = new EnumValueAutoCompleter(VmPoolType.class);
Line 39: } else {
Line 40: }
Line 41: return retval;
--
To view, visit http://gerrit.ovirt.org/7228
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I29de43c643be8cd0bc367c487f2e1d5c50b41e74
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
