Juan Hernandez has posted comments on this change. Change subject: core: fixing pom to include apache commons-lang. ......................................................................
Patch Set 1: Allon is right. Whenever you need to import a class from a new package you should update the POM to include the dependency, as you did, but in this particular case it is better to use "TYPE".equals(...), that doesn't require any change to the POM. -- To view, visit http://gerrit.ovirt.org/7228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29de43c643be8cd0bc367c487f2e1d5c50b41e74 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
