Oved Ourfali has posted comments on this change. Change subject: event map: render optional. ......................................................................
Patch Set 5: Code-Review+2 (1 comment) See minor comment, and consider fixing it better in a new patch. Fix DB numbering and then talk to me, and I'll merge it. http://gerrit.ovirt.org/#/c/31776/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddEventSubscriptionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddEventSubscriptionCommand.java: Line 40: if (eventNotificationMethod != null) { Line 41: // Validate user Line 42: DbUser user = DbFacade.getInstance().getDbUserDao().get(subscriberId); Line 43: if (user == null) { Line 44: addCanDoActionMessage(VdcBllMessages.USER_MUST_EXIST_IN_DB); just a thought, to move this logic to the base command class. Line 45: retValue = false; Line 46: } else { Line 47: retValue = ValidateAdd(eventNotificationMethod, getParameters().getEventSubscriber(), user); Line 48: } -- To view, visit http://gerrit.ovirt.org/31776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93d39249c9b57802948f356b5f0ad470ab7f32b1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Anonymous Coward #1000397 Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
