Oved Ourfali has submitted this change and it was merged. Change subject: event map: render optional. ......................................................................
event map: render optional. Event map currently must contain 'UNASSIGNED' for each event that does not have a down event. This means that the list of events is maintained twice (AuditLogType and event_map) and occasionally creates bugs[1]. I'm suggesting to make event map optional so that only events that are actually linked with a down event will be in the table. Event registration/deletion side (commands) need not be aware of the existence of event map since only the notifier uses it. [1] https://bugzilla.redhat.com/1119285 Change-Id: I93d39249c9b57802948f356b5f0ad470ab7f32b1 Signed-off-by: Mooli Tayer <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddEventSubscriptionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveEventSubscriptionCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java M packaging/dbscripts/event_sp.sql A packaging/dbscripts/upgrade/03_06_0690_render_event_map_optional.sql 7 files changed, 37 insertions(+), 77 deletions(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93d39249c9b57802948f356b5f0ad470ab7f32b1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Anonymous Coward #1000397 Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
