Oved Ourfali has posted comments on this change. Change subject: engine: Add unit-tests for fence-proxy selection ......................................................................
Patch Set 1: (2 comments) Seems like some code changes here aren't related to the tests. I guess they should be put in another patch, if needed. http://gerrit.ovirt.org/#/c/36419/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java: Line 52: * Line 53: */ Line 54: public VDSFenceReturnValue checkStatus() { Line 55: VDSFenceReturnValue returnValue = null; Line 56: VDS proxyHost = new FenceProxyLocator(_vds, fencingPolicy).findProxyHost(); what's this change? Line 57: if (proxyHost == null) { Line 58: returnValue = proxyNotFound(); Line 59: } else { Line 60: for (FenceAgent agent : _vds.getFenceAgents()) { http://gerrit.ovirt.org/#/c/36419/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceProxyLocator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceProxyLocator.java: Line 178: OTHER_DC; Line 179: }; Line 180: Line 181: public FencingPolicy getFencingPolicy() { Line 182: return fencingPolicy; what's this? Line 183: } Line 184: Line 185: public void setFencingPolicy(FencingPolicy fencingPolicy) { Line 186: this.fencingPolicy = fencingPolicy; -- To view, visit http://gerrit.ovirt.org/36419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f00b38c78ef7b6a72ee141d9090bf5e60eb679 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
