Oved Ourfali has posted comments on this change.

Change subject: engine: Add unit-tests for fence-proxy selection
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/36419/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceProxyLocator.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceProxyLocator.java:

Line 178:         OTHER_DC;
Line 179:     };
Line 180: 
Line 181:     public FencingPolicy getFencingPolicy() {
Line 182:         return fencingPolicy;
> what's this?
Oh. I haven't noticed that the test uses that.
Line 183:     }
Line 184: 
Line 185:     public void setFencingPolicy(FencingPolicy fencingPolicy) {
Line 186:         this.fencingPolicy = fencingPolicy;


-- 
To view, visit http://gerrit.ovirt.org/36419
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95f00b38c78ef7b6a72ee141d9090bf5e60eb679
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin PeÅ™ina <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to