Daniel Erez has posted comments on this change. Change subject: webadmin: Preventing moving a shareable disk to a Gluster domain ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/36359/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-12-28 15:27:28 +0200 Line 6: Line 7: webadmin: Preventing moving a shareable disk to a Gluster domain Line 8: Line 9: Gluster domian does not support shareable disks- therefore s/domian/domain Line 10: UI now prevents this action. Line 11: Line 12: Change-Id: Ibc2ea43f2131056c6f9ea86ecfb574fe71b638be Line 13: Bug-Url: https://bugzilla.redhat.com/1135771 http://gerrit.ovirt.org/#/c/36359/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java: Line 151: } Line 152: Line 153: protected void onInitStorageDomains(ArrayList<StorageDomain> storages, Disk disk) { Line 154: for (StorageDomain storage : storages) { Line 155: if (Linq.isDataActiveStorageDomain(storage) && isDiskValidForStorage(disk, storage)) { why checking only the first disk? What about moving/coping multiple disks? Line 156: getActiveStorageDomains().add(storage); Line 157: } Line 158: } Line 159: Collections.sort(getActiveStorageDomains(), new NameableComparator()); -- To view, visit http://gerrit.ovirt.org/36359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc2ea43f2131056c6f9ea86ecfb574fe71b638be Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
