Daniel Erez has posted comments on this change. Change subject: webadmin: Preventing moving a shareable disk to a Gluster domain ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/36359/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java: Line 215: sortDisks(); Line 216: postCopyOrMoveInit(); Line 217: } Line 218: Line 219: private ArrayList<StorageDomain> getDestinationDomains(ArrayList<StorageDomain> activeStorageDomains, renaming should be extracted to the refactoring patch, not really relevant here... Line 220: ArrayList<StorageDomain> sourceStorageDomainsToExclude, DiskModel diskModel, boolean isDiskBasedOnTemplate) { Line 221: Line 222: boolean shouldFilterBySourceType = isFilterDestinationDomainsBySourceType(diskModel); Line 223: DiskImage diskImage = ((DiskImage) diskModel.getDisk()); http://gerrit.ovirt.org/#/c/36359/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/CopyDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/CopyDiskModel.java: Line 46: } Line 47: Line 48: @Override Line 49: protected void initStorageDomains() { Line 50: final Disk disk = getDisks().get(0).getDisk(); can be reverted.. Line 51: if (disk.getDiskStorageType() != DiskStorageType.IMAGE) { Line 52: return; Line 53: } Line 54: http://gerrit.ovirt.org/#/c/36359/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java: Line 55: } Line 56: Line 57: @Override Line 58: protected void initStorageDomains() { Line 59: final Disk disk = getDisks().get(0).getDisk(); same Line 60: if (disk.getDiskStorageType() != DiskStorageType.IMAGE) { Line 61: return; Line 62: } Line 63: -- To view, visit http://gerrit.ovirt.org/36359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc2ea43f2131056c6f9ea86ecfb574fe71b638be Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
