Lior Vernia has posted comments on this change. Change subject: core: Adding 3.6 support ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/36518/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 200: select fn_db_add_config_value_for_versions_up_to('MomPoliciesOnHostSupported', 'false', '3.2'); Line 201: select fn_db_add_config_value_for_versions_up_to('NetworkQosSupported', 'false', '3.2'); Line 202: select fn_db_add_config_value_for_versions_up_to('StorageQosSupported', 'false', '3.4'); Line 203: select fn_db_add_config_value_for_versions_up_to('CpuQosSupported', 'false', '3.4'); Line 204: select fn_db_add_config_value_for_versions_up_to('HostNetworkQosSupported', 'false', '3.6'); This should stay 3.5 - feature was merged now for 3.6 (and default was set to true in the Java code). Line 205: select fn_db_add_config_value_for_versions_up_to('CloudInitSupported', 'false', '3.2'); Line 206: select fn_db_add_config_value('DefaultSysprepLocale','en_US','general'); Line 207: select fn_db_add_config_value_for_versions_up_to('ImportGlanceImageAsTemplate', 'false', '3.3'); Line 208: select fn_db_add_config_value_for_versions_up_to('HotPlugDiskSnapshotSupported', 'false', '3.2'); Line 573: Line 574: -- Network Custom Properties Line 575: select fn_db_add_config_value_for_versions_up_to('NetworkCustomPropertiesSupported', 'false', '3.4'); Line 576: select fn_db_add_config_value_for_versions_up_to('PreDefinedNetworkCustomProperties', $q$bridge_opts=^[^\s=]+=[^\s=]+(\s+[^\s=]+=[^\s=]+)*$$q$, '3.6'); -- tag prevents psql from escaping backslashes ('q' is arbitrary) Line 577: select fn_db_add_config_value_for_versions_up_to('UserDefinedNetworkCustomProperties', '', '3.6'); I don't think it'll do any harm to have those config values in older cluster compatibility versions, but does it make sense to have it for something < 3.5 when the feature itself wasn't supported? It basically means users will be able to configure this stuff, but it'll take no effect - which could be confusing. So do we want to allow configuring it at all? Line 578: Line 579: select fn_db_add_config_value_for_versions_up_to('SshSoftFencingCommand', 'service vdsmd restart', '3.2'); Line 580: select fn_db_add_config_value_for_versions_up_to('SshSoftFencingCommand', '/usr/bin/vdsm-tool service-restart vdsmd', '3.6'); Line 581: -- To view, visit http://gerrit.ovirt.org/36518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7354f13aabc27f0306afd4f1d2be54f9e71126a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
