Eli Mesika has posted comments on this change. Change subject: core: Adding 3.6 support ......................................................................
Patch Set 1: (10 comments) http://gerrit.ovirt.org/#/c/36518/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 89: select fn_db_add_config_value('ClusterEmulatedMachines','rhel6.3.0,pc-1.0','3.1'); Line 90: select fn_db_add_config_value('ClusterEmulatedMachines','rhel6.4.0,pc-1.0','3.2'); Line 91: select fn_db_add_config_value('ClusterEmulatedMachines','rhel6.4.0,pc-1.0,pseries','3.3'); Line 92: select fn_db_add_config_value_for_versions_up_to('ClusterEmulatedMachines','rhel6.5.0,pc-1.0,pseries','3.5'); Line 93: select fn_db_add_config_value('ClusterEmulatedMachines','rhel7.0.0,pc-1.0,pseries','3.6'); > looking at getVdsCaps on VDSM running on RHEL 7.0, I see: will check , thanks Line 94: select fn_db_add_config_value('CpuOverCommitDurationMinutes','2','general'); Line 95: --Handling Data directory for ENGINE Line 96: select fn_db_add_config_value('DataDir','/usr/share/engine','general'); Line 97: select fn_db_add_config_value('DBEngine','Postgres','general'); Line 89: select fn_db_add_config_value('ClusterEmulatedMachines','rhel6.3.0,pc-1.0','3.1'); Line 90: select fn_db_add_config_value('ClusterEmulatedMachines','rhel6.4.0,pc-1.0','3.2'); Line 91: select fn_db_add_config_value('ClusterEmulatedMachines','rhel6.4.0,pc-1.0,pseries','3.3'); Line 92: select fn_db_add_config_value_for_versions_up_to('ClusterEmulatedMachines','rhel6.5.0,pc-1.0,pseries','3.5'); Line 93: select fn_db_add_config_value('ClusterEmulatedMachines','rhel7.0.0,pc-1.0,pseries','3.6'); > we're not *yet* ready to use the new machine types, please use the same as Done Line 94: select fn_db_add_config_value('CpuOverCommitDurationMinutes','2','general'); Line 95: --Handling Data directory for ENGINE Line 96: select fn_db_add_config_value('DataDir','/usr/share/engine','general'); Line 97: select fn_db_add_config_value('DBEngine','Postgres','general'); Line 160: select fn_db_add_config_value_for_versions_up_to('GlusterAsyncTasksSupport', 'false', '3.3'); Line 161: select fn_db_add_config_value('GlusterPeerStatusRetries', '2', 'general'); Line 162: select fn_db_add_config_value('GlusterTaskMinWaitForCleanupInMins', '10', 'general'); Line 163: -- Gluster Geo-replication -- Line 164: select fn_db_add_config_value_for_versions_up_to('GlusterGeoReplicationEnabled', 'false', '3.6'); > Should be 3.5, as geo_replication feature support is being merged for 3.6 Done Line 165: select fn_db_add_config_value('GlusterRefreshRateGeoRepStatus', '300', 'general'); Line 166: select fn_db_add_config_value('GlusterRefreshRateGeoRepDiscovery', '3600', 'general'); Line 167: Line 168: -- OpenStack related Line 200: select fn_db_add_config_value_for_versions_up_to('MomPoliciesOnHostSupported', 'false', '3.2'); Line 201: select fn_db_add_config_value_for_versions_up_to('NetworkQosSupported', 'false', '3.2'); Line 202: select fn_db_add_config_value_for_versions_up_to('StorageQosSupported', 'false', '3.4'); Line 203: select fn_db_add_config_value_for_versions_up_to('CpuQosSupported', 'false', '3.4'); Line 204: select fn_db_add_config_value_for_versions_up_to('HostNetworkQosSupported', 'false', '3.6'); > This should stay 3.5 - feature was merged now for 3.6 (and default was set Done Line 205: select fn_db_add_config_value_for_versions_up_to('CloudInitSupported', 'false', '3.2'); Line 206: select fn_db_add_config_value('DefaultSysprepLocale','en_US','general'); Line 207: select fn_db_add_config_value_for_versions_up_to('ImportGlanceImageAsTemplate', 'false', '3.3'); Line 208: select fn_db_add_config_value_for_versions_up_to('HotPlugDiskSnapshotSupported', 'false', '3.2'); Line 220: -- Mixed domain types in a data center support Line 221: select fn_db_add_config_value_for_versions_up_to('MixedDomainTypesInDataCenter', 'false', '3.3'); Line 222: Line 223: -- default requirement for rng sources (comma-separated string of 'RANDOM' and 'HWRNG') Line 224: select fn_db_add_config_value_for_versions_up_to('ClusterRequiredRngSourcesDefault', '', '3.6'); > not sure about this one.. maybe should be RANDOM for 3.6.. Leaving as is until change is approved Line 225: Line 226: select fn_db_add_config_value_for_versions_up_to('SpiceCopyPasteToggleSupported', 'false', '3.4'); Line 227: -- Graphics Framebuffer Device support Line 228: select fn_db_add_config_value_for_versions_up_to('GraphicsDeviceEnabled','false','3.6'); Line 226: select fn_db_add_config_value_for_versions_up_to('SpiceCopyPasteToggleSupported', 'false', '3.4'); Line 227: -- Graphics Framebuffer Device support Line 228: select fn_db_add_config_value_for_versions_up_to('GraphicsDeviceEnabled','false','3.6'); Line 229: Line 230: select fn_db_add_config_value_for_versions_up_to('SpiceFileTransferToggleSupported', 'false', '3.6'); > This should stay 3.5 - feature merged Done Line 231: select fn_db_add_config_value_for_versions_up_to('StoragePoolMemoryBackend', 'false', '3.4'); Line 232: Line 233: select fn_db_add_config_value_for_versions_up_to('JsonProtocolSupported', 'false', '3.4'); Line 234: select fn_db_add_config_value_for_versions_up_to('VmSlaPolicySupported', 'false', '3.4'); Line 234: select fn_db_add_config_value_for_versions_up_to('VmSlaPolicySupported', 'false', '3.4'); Line 235: Line 236: select fn_db_add_config_value_for_versions_up_to('ReportedDisksLogicalNames', 'false', '3.4'); Line 237: Line 238: select fn_db_add_config_value_for_versions_up_to('AutoConvergenceSupported','false','3.6'); > This should stay 3.5 - feature merged Done Line 239: Line 240: select fn_db_add_config_value_for_versions_up_to('MigrationCompressionSupported','false','3.6'); Line 241: Line 242: -- by default use no proxy Line 236: select fn_db_add_config_value_for_versions_up_to('ReportedDisksLogicalNames', 'false', '3.4'); Line 237: Line 238: select fn_db_add_config_value_for_versions_up_to('AutoConvergenceSupported','false','3.6'); Line 239: Line 240: select fn_db_add_config_value_for_versions_up_to('MigrationCompressionSupported','false','3.6'); > This should stay 3.5 - feature merged Done Line 241: Line 242: -- by default use no proxy Line 243: select fn_db_add_config_value('SpiceProxyDefault','','general'); Line 244: Line 573: Line 574: -- Network Custom Properties Line 575: select fn_db_add_config_value_for_versions_up_to('NetworkCustomPropertiesSupported', 'false', '3.4'); Line 576: select fn_db_add_config_value_for_versions_up_to('PreDefinedNetworkCustomProperties', $q$bridge_opts=^[^\s=]+=[^\s=]+(\s+[^\s=]+=[^\s=]+)*$$q$, '3.6'); -- tag prevents psql from escaping backslashes ('q' is arbitrary) Line 577: select fn_db_add_config_value_for_versions_up_to('UserDefinedNetworkCustomProperties', '', '3.6'); > I don't think it'll do any harm to have those config values in older cluste Done Line 578: Line 579: select fn_db_add_config_value_for_versions_up_to('SshSoftFencingCommand', 'service vdsmd restart', '3.2'); Line 580: select fn_db_add_config_value_for_versions_up_to('SshSoftFencingCommand', '/usr/bin/vdsm-tool service-restart vdsmd', '3.6'); Line 581: Line 767: select fn_db_update_config_value('ClusterEmulatedMachines','rhel6.4.0,pc-1.0,pseries','3.3'); Line 768: select fn_db_update_config_value('SpiceDriverNameInGuest','{"windows": "RHEV-Spice", "linux" : "xorg-x11-drv-qxl" }','general'); Line 769: select fn_db_update_config_value('SupportedClusterLevels','3.0,3.1,3.2,3.3,3.4,3.5,3.6','general'); Line 770: select fn_db_update_config_value('SupportedStorageFormats','0,2,3','3.1,3.2,3.3,3.4,3.5,3.6'); Line 771: select fn_db_update_config_value('SupportedVDSMVersions','4.9,4.10,4.11,4.12,4.13,4.14,4.15','general'); > shouldn't it be bumped up here for 3.6 vdsm too? Yes , already done in a separate patch , you will see it now after I had rebased on master Line 772: select fn_db_update_config_value('VdcVersion','3.6.0.0','general'); Line 773: select fn_db_update_config_value('ProductRPMVersion','3.6.0.0','general'); Line 774: select fn_db_update_config_value('VdsFenceOptionMapping','alom:secure=secure,port=ipport;apc:secure=secure,port=ipport,slot=port;bladecenter:secure=secure,port=ipport,slot=port;drac5:secure=secure,port=ipport;eps:slot=port;ilo:secure=ssl,port=ipport;ipmilan:;rsa:secure=secure,port=ipport;rsb:;wti:secure=secure,port=ipport,slot=port','3.0'); Line 775: select fn_db_update_config_value('VdsFenceOptionMapping','alom:secure=secure,port=ipport;apc:secure=secure,port=ipport,slot=port;bladecenter:secure=secure,port=ipport,slot=port;drac5:secure=secure,port=ipport;eps:slot=port;ilo:secure=ssl,port=ipport;ipmilan:;rsa:secure=secure,port=ipport;rsb:;wti:secure=secure,port=ipport,slot=port','3.1'); -- To view, visit http://gerrit.ovirt.org/36518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7354f13aabc27f0306afd4f1d2be54f9e71126a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
