Yair Zaslavsky has posted comments on this change.
Change subject: core: Performance enhancement for DAO test cases
......................................................................
Patch Set 1: (1 inline comment)
I really like the basic idea - good work on that, Shireesh.
I think we might be missing some functionality here, see inline comment.
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java
Line 99:
Line 100: @NotTransactional
Line 101: @BeforeClass
Line 102: public static void initTestCase() throws Exception {
Line 103: if(dataSource == null) {
I would prefer to have some flexibility here to control if to perform init only
once, or per test case.
I'm afraid we might reach a situation in which Test for DAO changes data, which
might inflict the results of another Test of a DAO which is "logically close".
Line 104: dataSource = createDataSource();
Line 105: Connection con = dataSource.getConnection();
Line 106: con.setAutoCommit(false);
Line 107:
--
To view, visit http://gerrit.ovirt.org/7336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75afb85ba154808cd3254a1310e0350e6c4279fa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
