Allon Mureinik has posted comments on this change.
Change subject: core: Performance enhancement for DAO test cases
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
please remove the redundant method (see inline).
other than that, +1000 on the concept and the initiative.
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java
Line 112: }
Line 113: }
Line 114:
Line 115: @AfterClass
Line 116: public static void tearDownTestCase() throws Exception {
Just remove this method - it does nothing, and since it's static we know no
one's overriding it anyway...
Line 117: }
Line 118:
Line 119: @Before
Line 120: public void setUp() throws Exception {
--
To view, visit http://gerrit.ovirt.org/7336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75afb85ba154808cd3254a1310e0350e6c4279fa
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
