Vojtech Szocs has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout ......................................................................
Patch Set 2: > vojtech, I do not understand why it is important that engine session lives > one more minute, while it is inaccessible to remote. I mentioned the problematic use case in my previous comment... It can happen that idle WebAdmin GUI will auto-logout after time T > UserSessionTimeOutInterval. It can happen that UI plugin decides to make REST request in time T > UserSessionTimeOutInterval, because GUI still did not auto-logout, so all UI plugins are still active. But when this happens, REST HttpSession is *dead* and will result in "Auth Required" popup which we want to avoid. > I also not sure why the *2 is valid, but this is different discussion. See my inline comment in patchset 1 that quotes Einav. > Can you please explain me the actual problem if session is cleaned after a > short while? The problem is UI plugin trying to make REST request when REST HttpSession is dead, but GUI is still in "logged-in" mode because Engine session did not timeout yet. > You try to synchronize two different terms without me understanding the > benefit of creating dependency. Dependency = REST HttpSession is usable only when Engine session is alive. -- To view, visit http://gerrit.ovirt.org/36737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa95dba9b1f9647369bd817995c1cbd86f1e528f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
