Allon Mureinik has uploaded a new change for review.

Change subject: core: FB ImagesHandlerTest.getJsonDiskDescription
......................................................................

core: FB ImagesHandlerTest.getJsonDiskDescription

Remove useless initialization of the local variable jsonDescription to
null, as it's overridden on the very next line.

Change-Id: Iffac7367c23284527c9eaaf26511aaae627c7c4e
Signed-off-by: Allon Mureinik <[email protected]>
---
M 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/56/36756/1

diff --git 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
index 310f646..e187cbc 100644
--- 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
+++ 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
@@ -122,8 +122,7 @@
 
     @Test
     public void testJsonDiskDescription() throws IOException {
-        String jsonDescription = null;
-        jsonDescription = ImagesHandler.getJsonDiskDescription("DiskAlias", 
"DiskDescription");
+        String jsonDescription = 
ImagesHandler.getJsonDiskDescription("DiskAlias", "DiskDescription");
         assertEquals("Should be map of disk alias and disk description",
                 
"{\"DiskAlias\":\"DiskAlias\",\"DiskDescription\":\"DiskDescription\"}", 
jsonDescription);
     }


-- 
To view, visit http://gerrit.ovirt.org/36756
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iffac7367c23284527c9eaaf26511aaae627c7c4e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to