Yevgeny Zaspitsky has posted comments on this change. Change subject: core: make DbFacade a CDI singleton ......................................................................
Patch Set 35: (1 comment) http://gerrit.ovirt.org/#/c/34814/35/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java: Line 280: private DbFacade() { Line 281: } Line 282: Line 283: /** Line 284: * A way to keep backward compatibility with static getInstance() usage pattern. > I don't. But since it works in the ovirt flows - if anyone tries doing it t I guess that might be a bug. There is a race between dbFacade bean initialization and initialization and any other piece of code that calls getInstance method. Line 285: * @TODO once the code is cleaned from getInstance we could remove it. Line 286: */ Line 287: @PostConstruct Line 288: void init() { -- To view, visit http://gerrit.ovirt.org/34814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9e57710ce8353af020cb5ae53e43b127276d6c6 Gerrit-PatchSet: 35 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
