Juan Hernandez has posted comments on this change. Change subject: core,restapi: Glance import - custom disk and template name ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/37105/4/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 6590: action.async: xs:boolean Line 6591: action.grace_period.expiry: xs:long Line 6592: action.import_as_template: xs:boolean Line 6593: action.cluster.id|name: xs:string Line 6594: action.disk.alias: xs:string Can we support both "alias" and "name"? We already support both in many places, so it is better if we support both here as well. Line 6595: action.tempalte.name: xs:string Line 6596: urlparams: {} Line 6597: headers: Line 6598: Content-Type: {value: application/xml|json, required: true} Line 6591: action.grace_period.expiry: xs:long Line 6592: action.import_as_template: xs:boolean Line 6593: action.cluster.id|name: xs:string Line 6594: action.disk.alias: xs:string Line 6595: action.tempalte.name: xs:string The "tempalte" word is misspelled. Line 6596: urlparams: {} Line 6597: headers: Line 6598: Content-Type: {value: application/xml|json, required: true} Line 6599: Correlation-Id: {value: 'any string', required: false} http://gerrit.ovirt.org/#/c/37105/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResource.java: Line 54: } Line 55: Line 56: if (action.isSetDisk() && action.getDisk().isSetAlias()) { Line 57: importParameters.setDiskAlias(action.getDisk().getAlias()); Line 58: } Can we support both "alias" and "name"? If both are given then we should prefer "name" (that is what we do in DiskMapper). Line 59: Line 60: return doAction(VdcActionType.ImportRepoImage, importParameters, action); Line 61: } Line 62: -- To view, visit http://gerrit.ovirt.org/37105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19da074f7b6ae9d5a0c943c3a7dc6b90a3db03f0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
