Juan Hernandez has posted comments on this change. Change subject: core,restapi: Glance import - custom disk and template name ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/37105/5/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResource.java: Line 56: if (action.isSetDisk()) { Line 57: if (action.getDisk().isSetAlias()) { Line 58: importParameters.setDiskAlias(action.getDisk().getAlias()); Line 59: } Line 60: if (action.getDisk().isSetName()) { > if both "name" and "alias" are set, I'd think alias should take effect, no? Allon is right. I wrote exactly the contrary in my previous comment, but I was wrong. Sorry. Line 61: importParameters.setDiskAlias(action.getDisk().getName()); Line 62: } Line 63: } Line 64: -- To view, visit http://gerrit.ovirt.org/37105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19da074f7b6ae9d5a0c943c3a7dc6b90a3db03f0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
