Ravi Nori has posted comments on this change. Change subject: core : Change CreateAllSnapshotsFromVmCommand to not use placeholders mechanism ......................................................................
Patch Set 2: @Arik Very good point, since the parent command has not completed its execute phase its execute flag is false. So the one task that has been executed will endWithFailure because of the root commands executed=false. No issue here, verified it. -- To view, visit http://gerrit.ovirt.org/37146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6a6bba5d34e49efc06803ae042de9eb92fa3bc2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
