Liron Aravot has posted comments on this change. Change subject: core : Change CreateAllSnapshotsFromVmCommand to not use placeholders mechanism ......................................................................
Patch Set 2: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/37146/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java: Line 84: getReturnValue().setActionReturnValue(newDiskImage); Line 85: setSucceeded(true); Line 86: } Line 87: Line 88: protected boolean processImageInIrs() { 1. this file isn't related to the create snapshot flow. 2. do you persist the placeholder to keep it compatible with the rest of the code? Line 89: Guid taskId = persistAsyncTaskPlaceHolder(getParameters().getParentCommand()); Line 90: VDSReturnValue vdsReturnValue = runVdsCommand( Line 91: VDSCommandType.CreateImage, Line 92: new CreateImageVDSCommandParameters(getParameters().getStoragePoolId(), getParameters() http://gerrit.ovirt.org/#/c/37146/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 253: for (DiskImage image : getDisksList()) { Line 254: VdcReturnValueBase vdcReturnValue = Backend.getInstance().runInternalAction( Line 255: VdcActionType.CreateSnapshot, Line 256: buildCreateSnapshotParameters(image), Line 257: cloneContextAndDetachFromParent()); why cloneContextAndDetachFromParent()? that means that under the tasks tab the child commands won't appear under the create snapshot for vm. Line 258: Line 259: if (vdcReturnValue.getSucceeded()) { Line 260: getTaskIdList().addAll(vdcReturnValue.getInternalVdsmTaskIdList()); Line 261: } else { -- To view, visit http://gerrit.ovirt.org/37146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6a6bba5d34e49efc06803ae042de9eb92fa3bc2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
