Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: replace == to equals ......................................................................
webadmin: replace == to equals It is not a good practice to rely on the "==" even it mostly passes since: - in production mode it translates to javascript and the "==" is ok there - in devel mode the same strings are commonly represented inside the JVM as one object so it mostly passes. But in java it is just not a good practice and it is not reliable Change-Id: Ic5deb1807573fa9944ede7ea09650f68571e0d6d Signed-off-by: Tomas Jelinek <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/10/37310/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java index 87180ad..148f828 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java @@ -1623,7 +1623,7 @@ @Override public void eventRaised(Event<? extends PropertyChangedEventArgs> ev, Object sender, PropertyChangedEventArgs args) { - if (args.propertyName == "IsAvailable") { //$NON-NLS-1$ + if ("IsAvailable".equals(args.propertyName)) { //$NON-NLS-1$ isVirtioScsiEnabledInfoIcon.setVisible(object.getIsVirtioScsiEnabled().getIsAvailable()); } } @@ -1633,7 +1633,7 @@ @Override public void eventRaised(Event<? extends PropertyChangedEventArgs> ev, Object sender, PropertyChangedEventArgs args) { - if (args.propertyName == "SelectedItem") { //$NON-NLS-1$ + if ("SelectedItem".equals(args.propertyName)) { //$NON-NLS-1$ updateUsbNativeMessageVisibility(object); } } -- To view, visit http://gerrit.ovirt.org/37310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic5deb1807573fa9944ede7ea09650f68571e0d6d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
