Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: replace == to equals ......................................................................
webadmin: replace == to equals It is not a good practice to rely on the "==" even it mostly passes since: - in production mode it translates to javascript and the "==" is ok there - in devel mode the same strings are commonly represented inside the JVM as one object so it mostly passes. But in java it is just not a good practice and it is not reliable Change-Id: Ic5deb1807573fa9944ede7ea09650f68571e0d6d Signed-off-by: Tomas Jelinek <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5deb1807573fa9944ede7ea09650f68571e0d6d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
