Juan Hernandez has posted comments on this change. Change subject: restapi: Add CORS filter ......................................................................
Patch Set 7: Verified+1 When testing with Chrome I found two issues? 1. Chrome will initially not accept to connect to the engine HTTPS server, because of the not trusted CA certificate. I had to manually import the CA certificate. I guess this happened to me because it is the first time I use Chrome to connect to that engine. With Firefox things are easier because it allows you to import/trust the CA certificate automatically when you connect. This shouldn't be a blocker for this patch, in my opinion. 2. The second issue is that Chrome is sending an additional header value in the "Access-Control-Request-Headers" header. It send the following: accept,authorization,content-type Firefox doesn't send "accept", only "authorization" and "content-type". The problem is that the configuration of the filter lists the allowed headers, and "accept" wasn't included. That is fixed in this patch set. After solving these two issues I tested again with Firefox and Chrome, and both work correctly. I also changed a bit the example HTML, as I realized that the third parameter to "XMLHttpRequest.open" isn't needed. It was using sync requests, and it is now using async requests. Anyhow, this change isn't related to the failure in Chrome. -- To view, visit http://gerrit.ovirt.org/36367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40f9a13105fe99bb6b4035e61b8945efd8315f57 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Jenny Kang <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
