Oved Ourfali has posted comments on this change.
Change subject: [WIP] core: setting proper timeout mechanism for GetRootDSE
(#844733)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSE.java
Line 40: private void execute(LdapProviderType ldapProviderType, String
domain) {
Line 41: Hashtable<String, String> env = new Hashtable<String,
String>();
Line 42: int timeLimit = Config.<Integer>
GetValue(ConfigValues.LDAPQueryTimeout) * 1000;
Line 43: env.put("com.sun.jndi.ldap.connect.timeout",
Long.toString(timeLimit));
Line 44: initContextVariables(env);
Nice!
Makes me wonder, is it needed in other locations of the code as well?
Line 45:
Line 46: Attributes results = null;
Line 47:
Line 48: DirContext ctx = null;
--
To view, visit http://gerrit.ovirt.org/7479
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6579
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
