Oved Ourfali has posted comments on this change.
Change subject: core: setting proper timeout mechanism for GetRootDSE (#844733)
......................................................................
Patch Set 4: (2 inline comments)
minor comments
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 181: --Handling Keystore URL
Line 182: select fn_db_add_config_value('keystoreUrl','.keystore','general');
Line 183: select fn_db_add_config_value('LdapQueryPageSize','1000','general');
Line 184: select fn_db_add_config_value('LDAPQueryTimeout','30','general');
Line 185: select fn_db_add_config_value('LDAPConnectTimeout','5','general');
do we indeed want it to be 5? isn't it too short?
Line 186: select fn_db_add_config_value('LDAPOperationTimeout','30','general');
Line 187: --Handling LDAP Security Authentication Method
Line 188: select
fn_db_add_config_value('LDAPSecurityAuthentication','GSSAPI','general');
Line 189: select fn_db_add_config_value('LDAPServerPort','389','general');
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSE.java
Line 58:
searchControls.setReturningAttributes(queryExecution.getReturningAttributes());
Line 59:
searchControls.setSearchScope(queryExecution.getSearchScope());
Line 60: // Added this in order to prevent a warning saying: "the
returning obj flag wasn't set, setting it to true"
Line 61: searchControls.setReturningObjFlag(true);
Line 62: searchControls.setTimeLimit(Config.<Integer>
GetValue(ConfigValues.LDAPOperationTimeout) * 1000);
[optional] you can add a method returning this value in ldap broker utils, and
use it both there and in this line of code.
Line 63: NamingEnumeration<SearchResult> search =
Line 64: ctx.search(queryExecution.getBaseDN(),
queryExecution.getFilter(), searchControls);
Line 65:
Line 66: try {
--
To view, visit http://gerrit.ovirt.org/7479
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6579
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
