Arik Hadas has posted comments on this change.

Change subject: core: Removed redundant storage allocation for stateless VM
......................................................................


Patch Set 4: Code-Review-1

I think that moving this check from the can-do-action phase to the execute 
phase will be problematic in case of running multiple actions as only 
can-do-action is executed by the caller thread and then the execute method 
might be executed in a different thread.

Vered, can you verify if the message is presented in the UI when running 
multiple VMs together?

-- 
To view, visit http://gerrit.ovirt.org/37446
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29deabd07d23c5b560b8fca51a9831d026d04ab8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Ala Hino <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Amit Aviram <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Idan Shaby <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to