Omer Frenkel has posted comments on this change. Change subject: engine: informative message for vm console connect(#833730) ......................................................................
Patch Set 1: (1 inline comment) comment inside, also missing changes to properties files, please follow: http://wiki.ovirt.org/wiki/Engine_Adding_Messages .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/PermissionSubject.java Line 8: public class PermissionSubject { Line 9: private Guid objectId; Line 10: private VdcObjectType ObjectType; Line 11: private ActionGroup actionGroup; Line 12: private VdcBllMessages message; why not giving the default value here, and save the if..else later? Line 13: Line 14: public PermissionSubject(Guid objectId, VdcObjectType objectType, ActionGroup actionGroup) { Line 15: this(objectId, objectType, actionGroup, null); Line 16: } -- To view, visit http://gerrit.ovirt.org/7496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9fadff662f0d63fd27bacfbf7d765917271932d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Noam Slomianko <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
