Omer Frenkel has posted comments on this change.
Change subject: engine: informative message for vm console connect(#833730)
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/PermissionSubject.java
Line 11: private ActionGroup actionGroup;
Line 12: private VdcBllMessages message =
VdcBllMessages.USER_NOT_AUTHORIZED_TO_PERFORM_ACTION;
Line 13:
Line 14: public PermissionSubject(Guid objectId, VdcObjectType objectType,
ActionGroup actionGroup) {
Line 15: this(objectId, objectType, actionGroup, null);
most places use this ctor, so message will be null
Line 16: }
Line 17:
Line 18: public PermissionSubject(Guid objectId, VdcObjectType objectType,
ActionGroup actionGroup,
Line 19: VdcBllMessages message) {
--
To view, visit http://gerrit.ovirt.org/7496
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9fadff662f0d63fd27bacfbf7d765917271932d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
