Moti Asayag has posted comments on this change. Change subject: core, restapi: reporting & removal of unmanaged networks. ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/37525/4/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 3805: <xs:complexType name="UnmanagedNetwork"> Line 3806: <xs:complexContent> Line 3807: <xs:extension base="BaseResource"> Line 3808: <xs:sequence> Line 3809: <xs:element name="unmanaged_network_name" type="xs:string" minOccurs="1" maxOccurs="1"/> > The base "BaseResource" already has a "name" attribute, can we use it inste +1, in addition, the name of the network will be used as the identifier of that network. Since we would like to support at some point any network name, i guess we should use the hex2string and string2hex to convert the name to/from the id. Line 3810: <xs:element name="nic_name" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 3811: <xs:element name="nic_id" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 3812: </xs:sequence> Line 3813: </xs:extension> Line 3807: <xs:extension base="BaseResource"> Line 3808: <xs:sequence> Line 3809: <xs:element name="unmanaged_network_name" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3810: <xs:element name="nic_name" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 3811: <xs:element name="nic_id" type="xs:string" minOccurs="0" maxOccurs="1"/> > Does it make sense to re-use the already existing "HostNIC" complex type? I +1, also have the same comment on the discussion here: http://lists.ovirt.org/pipermail/users/2015-February/031105.html Line 3812: </xs:sequence> Line 3813: </xs:extension> Line 3814: Line 3815: </xs:complexContent> -- To view, visit http://gerrit.ovirt.org/37525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcf6e1292ce6f3a335051123be8c3389e8230bf0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
