Juan Hernandez has posted comments on this change. Change subject: core, restapi: reporting & removal of unmanaged networks. ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/37525/4/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UnmanagedNetworkMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UnmanagedNetworkMapper.java: Line 13: Line 14: UnmanagedNetworkBusinessEntity entity = template == null ? new UnmanagedNetworkBusinessEntity() : template; Line 15: Line 16: if (model.isSetId()) { Line 17: entity.setId(model.getUnmanagedNetworkName()); > sounds good to me. Note that I think that searching by name (or by any other criteria) in a collection like this, with probably only a few elements isn't probably important. The user can always get all the unregistered networks, iterate them and find the one it is looking for. I'd say that making the collection searchable is not worth the effort, but if you thing that it is *really* important then that is the right way to do things. Line 18: } Line 19: Line 20: if (model.isSetUnmanagedNetworkName()) { Line 21: entity.setNetworkName(model.getUnmanagedNetworkName()); -- To view, visit http://gerrit.ovirt.org/37525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcf6e1292ce6f3a335051123be8c3389e8230bf0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
