Muli Salem has posted comments on this change.
Change subject: core: Add null/empty support to IP Address pattern (#852076)
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IPAddressPatternTest.java
Line 26: this.expectedResult = expectedResult;
Line 27: }
Line 28:
Line 29: @Test
Line 30: public void checkIPAdress() {
typo: checkIPAddress
Line 31: Set<ConstraintViolation<IPAdress>> validate =
validator.validate(new IPAdress(address));
Line 32: assertEquals(validate.isEmpty(), expectedResult);
Line 33: }
Line 34:
Line 62: { " ", false },
Line 63: });
Line 64: }
Line 65:
Line 66: private class IPAdress {
same: IPAddress
Line 67:
Line 68: @Pattern(regexp = ValidationUtils.IP_PATTERN, message =
"NETWROK_ADDR_IN_STATIC_IP_BAD_FORMAT")
Line 69: private String address;
Line 70:
--
To view, visit http://gerrit.ovirt.org/7634
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8d38ebf880c72d86f956f7c08aefa12e1894109
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
