Sahina Bose has posted comments on this change. Change subject: engine: Peer probing with alternate addresses ......................................................................
Patch Set 2: (2 comments) Since the sync job runs every 5 second, did not add this in InitVdsOnUp. Will revisit again https://gerrit.ovirt.org/#/c/38149/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java: Line 252: return; Line 253: } Line 254: } Line 255: // if last but one host in cluster, update the last host's known addresses Line 256: if (getClusterUtils().getServerCount(getVdsGroupId()) == 2) { > what if the remove operation fails after this stage? There would be no issues in peer probing again, if known_addresses is empty. But will check this again Line 257: removeOtherKnowAddressesForGlusterServer(upServer.getId()); Line 258: } Line 259: } Line 260: } https://gerrit.ovirt.org/#/c/38149/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java: Line 277: Line 278: removeVdsStatisticsFromDb(server); Line 279: removeVdsDynamicFromDb(server); Line 280: removeVdsStaticFromDb(server); Line 281: > you might want to have the same logic of resetting known-addresses here as Yes..will add that Line 282: return null; Line 283: } Line 284: }); Line 285: } -- To view, visit https://gerrit.ovirt.org/38149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fa407d6a525e73b89a79d063517798283b520fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
