Sahina Bose has posted comments on this change. Change subject: engine: Peer probing with alternate addresses ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/38149/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java: Line 206: Line 207: // Check if only 1 host remaining in cluster, if so reset it's known address so that new host will Line 208: // be peer probed with this alternate address Line 209: private void checkAndResetKnownAddress(Guid clusterId) { Line 210: List<VDS> vdslist = getVdsDao().getAllForVdsGroup(clusterId); > server-list and the current server can be passed as argument since the call Done Line 211: if (vdslist.size() == 1) { Line 212: DbFacade.getInstance().getGlusterServerDao().updateKnownAddresses(vdslist.get(0).getId(), null); Line 213: } Line 214: } Line 238: } Line 239: } Line 240: } Line 241: Line 242: private Network findGlusterNetwork(VDS server) { > This function will be repeatedly called for every server though the return Changed to do it once for cluster. Line 243: List<Network> allNetworksInCluster = Line 244: DbFacade.getInstance().getNetworkDao().getAllForCluster(server.getVdsGroupId()); Line 245: Line 246: for (Network network : allNetworksInCluster) { -- To view, visit https://gerrit.ovirt.org/38149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fa407d6a525e73b89a79d063517798283b520fd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
