Piotr Kliczewski has posted comments on this change. Change subject: vdsbroker: reduced scope of synchronized blocks ......................................................................
Patch Set 1: (1 comment) Arik: Please keep in mind that objLock is used during host monitoring as well and we noticed congestion during the tests. We know that problem exists and I proposed following solution which was confirm to reduce congestion by running the same tests. If you have any other suggestions how to solve this issues please suggest. https://gerrit.ovirt.org/#/c/37947/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 554: mFailedToRunVmAttempts > what is the risk of using mFailedToRunVmAttempts outside of the lock? did y Performance tests that were run contains following steps based on customer experience: * POST Create VM * GET VM Status (till VM is Down) * POST VM Start * GET VM Status (till VM is UP) * SSH Command # date * POST VM Stop * GET VM Status (till VM is Down) * POST Create VM Template * GET Template Status (till Template is OK) * GET Template Disk UID * GET Storage UID * POST Copy Template Disk to Storage * GET Template Disk Status (till it is OK) * DELETE Template * DELETE VM Please let me know if you would like to extend above procedure to cover scenario that you suggest. -- To view, visit https://gerrit.ovirt.org/37947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d1bfd7b1fc7bfcc6465eae62feda6f1a27ff455 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tim Speetjens <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
