Allon Mureinik has posted comments on this change. Change subject: core: GetAllAttachableDisks - filter Illegal disks (#851201) ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) See inline. Also please add a test to the DAO to ensure this new functionality works. .................................................... File backend/manager/dbscripts/all_disks_sp.sql Line 59: RETURN QUERY SELECT distinct all_disks.* Line 60: FROM all_disks Line 61: WHERE (v_storage_pool_id IS NULL OR all_disks.storage_pool_id = v_storage_pool_id) Line 62: AND (all_disks.number_of_vms = 0 OR all_disks.shareable) Line 63: AND (all_disks.imagestatus IS NULL OR all_disks.imagestatus != 4) Suggestion: Please comment what 4 means - it's obvious in the context of this patch, but anyone looking at it later won't understand. Question: Are INVALID and LOCKED images attachable? Line 64: AND (v_vm_id IS NULL OR v_vm_id NOT IN (SELECT vm_id FROM vm_device WHERE vm_device.device_id = all_disks.image_group_id)) Line 65: AND (NOT v_is_filtered OR EXISTS (SELECT 1 Line 66: FROM user_disk_permissions_view Line 67: WHERE user_id = v_user_id AND entity_id = disk_id)); -- To view, visit http://gerrit.ovirt.org/7589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia302712c7c49f0818bbb44e46339b8e5867ce69c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
