Allon Mureinik has posted comments on this change. Change subject: core: GetAllAttachableDisks - filter Illegal disks (#851201) ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) please fix the TWS issue (see inline). Other than that - looks great. .................................................... File backend/manager/modules/dal/src/test/resources/fixtures.xml Line 1916: <value>2010-11-18 11:11:35</value> Line 1917: <value>2010-12-01 14:13:07</value> Line 1918: <value>88296e00-0cad-4e5a-9291-008a7b7f4401</value> Line 1919: <value>0</value> Line 1920: </row> please remove TWS. Line 1921: <row> Line 1922: <value>c9a559d9-8666-40d1-9967-759502b19f0c</value> Line 1923: <value>2010-11-18 11:03:50</value> Line 1924: <value>2147483648</value> -- To view, visit http://gerrit.ovirt.org/7589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia302712c7c49f0818bbb44e46339b8e5867ce69c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
