Maor Lipchuk has posted comments on this change. Change subject: core: determine wether domain monitoring result is actual ......................................................................
Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/38039/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java: Line 479: reportWhetherDomainMonitoringResultIsActual > all the methods in this class return a boolean, while their name is the nam ok, it is only a suggestion, I agree this class is not an example of java standard https://gerrit.ovirt.org/#/c/38039/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 2040: ReportWhetherDomainMonitoringResultIsActual > the names aren't unified - take a look please at the values here.. (for exa good example indeed :) I guess we should try to make standards in this class in another separate patch. https://gerrit.ovirt.org/#/c/38039/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java: Line 1232: boolean > yes, both will be false. isn't that will be confusing? Why not simply add after "if (domainMonitoringResult.invalid())" in the code, also "else if actual()"? Line 1234: Line 1235: private DomainMonitoringResult analyzeDomainReport(VDSDomainsData tempData, StoragePool storagePool, boolean isLog) { Line 1236: if (!tempData.isActual() && Line 1237: FeatureSupported.reportWhetherDomainMonitoringResultIsActual(storagePool.getCompatibilityVersion())) { Line 1238: log.error("Domain '{}' report isn't an actual report", > i'll change it to warn. I prefer to not add "Domain monitor has not yet mon I think it will be more informative, but it is not a must Line 1239: getDomainIdTuple(tempData.getDomainId())); Line 1240: return DomainMonitoringResult.NOT_ACTUAL; Line 1241: } Line 1242: -- To view, visit https://gerrit.ovirt.org/38039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddbba94d81694bd6cb1ce3648872eb81182a50ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
