Liron Aravot has posted comments on this change. Change subject: core: determine wether domain monitoring result is actual ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38039/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java: Line 1228: public boolean invalid() { Line 1229: return actual() && !valid; Line 1230: } Line 1231: Line 1232: public boolean actual() {return this != NOT_ACTUAL;} > I think this is a classic case of enum, since boolean does not cover all th If you'll take a look in the enum you'll see that there are multiple values. i'll change the method names as you suggested. Line 1233: } Line 1234: Line 1235: private DomainMonitoringResult analyzeDomainReport(VDSDomainsData tempData, StoragePool storagePool, boolean isLog) { Line 1236: if (!tempData.isActual() && -- To view, visit https://gerrit.ovirt.org/38039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddbba94d81694bd6cb1ce3648872eb81182a50ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
