Piotr Kliczewski has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/38271/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VMListReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VMListReturnForXmlRpc.java: Line 25: Object[] temp = (Object[]) innerMap.get(VM_LIST); Line 26: if (temp != null) { Line 27: mVmList = new HashMap[temp.length]; Line 28: for (int i = 0; i < temp.length; i++) { Line 29: if (String.class.isInstance(temp[i])) { > since it is indeed ugly i think it does deserve a comment Will add a comment clarifying the reason. Line 30: Map<String, Object> map = new HashMap<>(); Line 31: map.put("vmId", temp[i]); Line 32: mVmList[i] = map; Line 33: } else { -- To view, visit https://gerrit.ovirt.org/38271 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iade8c1d5954eaae4339e95d9d5031a7b98cf831b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
