Piotr Kliczewski has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/38271/4/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/jsonrpc/MarshallingTestCase.java File backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/jsonrpc/MarshallingTestCase.java: Line 269: throws > i dont understand how this tests works? it means the engine can accept the It is based on how you define expected type for FutureMap. When you take a look at change in JsonRpcVdsServer. There are 2 places where you define type. - for jackson to process json - in response processing code (VMListReturnForXmlRpc in this case) -- To view, visit https://gerrit.ovirt.org/38271 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iade8c1d5954eaae4339e95d9d5031a7b98cf831b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
