Tomas Jelinek has posted comments on this change. Change subject: webadmin: Allow actions on a VM list even if not available on all VMs ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38415/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java: Line 351: return true; Line 352: } Line 353: } Line 354: } Line 355: return false; if the type is not in the _matrix than you should return true, not false. Line 356: } -- To view, visit https://gerrit.ovirt.org/38415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f10f1992838ecef796989b83a6fa1f2e34d443 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
