Tal Nisan has posted comments on this change. Change subject: webadmin: Allow actions on a VM list even if not available on all VMs ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38415/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java: Line 2269: && VdcActionUtils.canExecutePartially(items, VM.class, VdcActionType.RunVm)); Line 2270: getCloneVmCommand().setIsExecutionAllowed(items.size() == 1 Line 2271: && VdcActionUtils.canExecute(items, VM.class, VdcActionType.CloneVm)); Line 2272: getPauseCommand().setIsExecutionAllowed(items.size() > 0 Line 2273: && VdcActionUtils.canExecutePartially(items, VM.class, VdcActionType.HibernateVm)); > remove completely the pause check? Not just change in a way that when some The command will be available for all VMs, if there will be a failure it will fail with a CDA in the worst case Line 2274: getShutdownCommand().setIsExecutionAllowed(items.size() > 0 Line 2275: && VdcActionUtils.canExecutePartially(items, VM.class, VdcActionType.ShutdownVm)); Line 2276: getStopCommand().setIsExecutionAllowed(items.size() > 0 Line 2277: && VdcActionUtils.canExecutePartially(items, VM.class, VdcActionType.StopVm)); -- To view, visit https://gerrit.ovirt.org/38415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f10f1992838ecef796989b83a6fa1f2e34d443 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
