Omer Frenkel has posted comments on this change. Change subject: database, core: Add the UserProfile entity ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/38012/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UserProfileDAO.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UserProfileDAO.java: Line 21: * @param userId Line 22: * the user id Line 23: * @return the user profile, or <code>null</code> if the id was invalid Line 24: */ Line 25: UserProfile getByUserId(Guid userId); can't a user have more than one profile (means, more than one ssh key, for example per pc or something like this?) Line 26: Line 27: /** Line 28: * Retrieves all user profiles. Line 29: * https://gerrit.ovirt.org/#/c/38012/1/packaging/dbscripts/user_profiles_sp.sql File packaging/dbscripts/user_profiles_sp.sql: Line 25: ssh_public_key) Line 26: VALUES( Line 27: v_profile_id, Line 28: v_user_id, Line 29: v_ssh_public_key); > I wounder if a profile of key, value is better to enable adding properties im in favor of a field for each property Line 30: END; $procedure$ Line 31: LANGUAGE plpgsql; Line 32: Line 33: -- To view, visit https://gerrit.ovirt.org/38012 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idca5769f84d379fd20a184608667a7774cc465c8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
