Alon Bar-Lev has posted comments on this change.

Change subject: database, core: Add the UserProfile entity
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/38012/1/packaging/dbscripts/user_profiles_sp.sql
File packaging/dbscripts/user_profiles_sp.sql:

Line 25:         ssh_public_key)
Line 26:     VALUES(
Line 27:         v_profile_id,
Line 28:         v_user_id,
Line 29:         v_ssh_public_key);
> im in favor of a field for each property
not sure why for each new property like theme color application need schema 
change.
Line 30: END; $procedure$
Line 31: LANGUAGE plpgsql;
Line 32: 
Line 33: 


-- 
To view, visit https://gerrit.ovirt.org/38012
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idca5769f84d379fd20a184608667a7774cc465c8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to