Ramesh N has posted comments on this change. Change subject: engine: vds commands for gluster brick create ......................................................................
Patch Set 14: (5 comments) https://gerrit.ovirt.org/#/c/36029/14/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJobTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJobTest.java: Line 445: GlusterServicesActionFailed > Is this change part of this patch ?? Yes. Error code 4409(GlusterServicesListFailed) is returned for create brick flow. So error GlusterServicesListFailed will not be returned by VDSM. So removing this error and reusing the error code for"HostStorageDeviceNotFoundException". https://gerrit.ovirt.org/#/c/36029/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/CreateBrickVDSParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/CreateBrickVDSParameters.java: Line 70: format > Would it print name value pair for raidParams? Also would it print all the Map.toString() will print all the key values in proper format. Storage Device implements the toString() so it will also print the values properly. https://gerrit.ovirt.org/#/c/36029/14/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties: Line 444: > %s/fstab entry is already exists for the device/fstab entry already exists Done https://gerrit.ovirt.org/#/c/36029/14/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java: Line 56: > Why removed ? This error was never returned by vdsm and error code given to this error is used for create brick error. https://gerrit.ovirt.org/#/c/36029/14/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java: Line 888: DefaultStringValue > same as earlier Done -- To view, visit https://gerrit.ovirt.org/36029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a74a9eeabd19b9780e4401d263e586261f488d Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
