Piotr Kliczewski has posted comments on this change. Change subject: engine: vds commands for gluster brick create ......................................................................
Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/36029/15/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java: Line 1725: String mountPoint, Line 1726: Map<String, Object> raidParams, Line 1727: String[] storageDevices) { Line 1728: try { Line 1729: if (raidParams == null) { As far as I remember vdsm code the default value is empty map so you could pass empty map here and have single method on VdsServerConnector interface. Line 1730: return new OneStorageDeviceReturnForXmlRpc(vdsServer.glusterCreateBrick(lvName, mountPoint, Line 1731: storageDevices)); Line 1732: } else { Line 1733: return new OneStorageDeviceReturnForXmlRpc(vdsServer.glusterCreateBrick(lvName, mountPoint, -- To view, visit https://gerrit.ovirt.org/36029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a74a9eeabd19b9780e4401d263e586261f488d Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
