Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: Inform the user about availability of DWH and Reports ......................................................................
Patch Set 21: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/38277/21/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/__init__.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/__init__.py: Line 29: @util.export Line 30: def createPlugins(context): Line 31: misc.Plugin(context=context) Line 32: advertise_dwh.Plugin(context=context) Line 33: please leave 2 new lines https://gerrit.ovirt.org/#/c/38277/21/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/advertise_dwh.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/advertise_dwh.py: Line 20: Line 21: Line 22: import gettext Line 23: import os.path Line 24: _ = lambda m: gettext.dgettext(message=m, domain='ovirt-engine-setup') please update above lambda with the def used in latest pep8 fixes as in the other plugins. Line 25: Line 26: Line 27: from otopi import util Line 28: from otopi import plugin Line 119: oenginecons.DWHCoreEnv.ENABLE Line 120: ) and not self.environment.get( Line 121: oenginecons.ReportsCoreEnv.ENABLE Line 122: ) and not self._dwhHost: Line 123: noteText = ( Please use localized string here: _(...) Line 124: 'Note! If you want to gather statistical' Line 125: ' information you can install Reports and/or DWH:\n' Line 126: ) Line 127: Line 181: text=_( Line 182: 'DWH detected.' Line 183: ) Line 184: ) Line 185: 2 new lines here too -- To view, visit https://gerrit.ovirt.org/38277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61fb88a6430eec6b6425075df0e749644654753a Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lev Veyde <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
