Alon Bar-Lev has posted comments on this change. Change subject: hosted-engine: WIP - allow to deploy hosted-engine ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/38547/7/src/plugins/ovirt-host-deploy/hosted-engine/configureha.py File src/plugins/ovirt-host-deploy/hosted-engine/configureha.py: Line 79: ca_cert=os.path.join( Line 80: odeploycons.FileLocations.VDSM_TRUST_STORE, Line 81: odeploycons.FileLocations.VDSM_SPICE_CA_FILE Line 82: ), Line 83: fqdn=self.environment[odeploycons.VdsmEnv.ENGINE_HOST], > I'm not sure it's really better to duplicate the info instead of re-using o there is no existing, this is for different reason, there is no reason to couple two modules. Line 84: ) Line 85: for env_key in self.environment: Line 86: if env_key.startswith( Line 87: odeploycons.HostedEngineEnv.HOSTED_ENGINE_CONFIG_PREFIX -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
