Sandro Bonazzola has posted comments on this change. Change subject: hosted-engine: WIP - allow to deploy hosted-engine ......................................................................
Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/38547/7/src/plugins/ovirt-host-deploy/hosted-engine/configureha.py File src/plugins/ovirt-host-deploy/hosted-engine/configureha.py: Line 61: ): Line 62: self.services.state( Line 63: name=service, Line 64: state=False, Line 65: ) > so we do not need to stop it, we can restart it as we do in packages. Done Line 66: Line 67: @plugin.event( Line 68: stage=plugin.Stages.STAGE_MISC, Line 69: condition=lambda self: self.environment[ Line 79: ca_cert=os.path.join( Line 80: odeploycons.FileLocations.VDSM_TRUST_STORE, Line 81: odeploycons.FileLocations.VDSM_SPICE_CA_FILE Line 82: ), Line 83: fqdn=self.environment[odeploycons.VdsmEnv.ENGINE_HOST], > you have full control over the variables at peer. I'm nto sure to follow. the HA daemon uses the engine fqdn for checking if it's alive. It gets the fqdn of the engine from the config file written here. If there's another way to get the engine fqdn when the engine is down we can open a BZ and change the HA daemon for not requiring this config line. At current state, fqdn line is needed for having the HA daemon to work AFAIK. Line 84: ) Line 85: for env_key in self.environment: Line 86: if env_key.startswith( Line 87: odeploycons.HostedEngineEnv.HOSTED_ENGINE_CONFIG_PREFIX https://gerrit.ovirt.org/#/c/38547/7/src/plugins/ovirt-host-deploy/hosted-engine/configureqemu.py File src/plugins/ovirt-host-deploy/hosted-engine/configureqemu.py: > this is still pending. I know, still waiting for fsimonce / msivak Line 1: # Line 2: # ovirt-host-deploy -- ovirt host deployer Line 3: # Copyright (C) 2015 Red Hat, Inc. Line 4: # -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
