Ori Liel has posted comments on this change. Change subject: core: Introduce SingleAgentFenceActionExecutor ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/38358/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java: Line 24: SingleAgentFenceActionExecutor How is this class different than FenceAgentExecutor which you've added in the previous patch? And how is it different to FenceExecutor? About FenceAgentExecutor you say: /** * Manages execution of the fence action on the host using single agent */ And about this class (SingleAgentFenceActionExecutor) you say: /** * Manages fence execution for the host using specified fence agent */ I can't tell the difference intuintively and effortlessly which tells me that there a good chance that either: a) there's redundancy, or b) something isn't right with the names or with the documentation. -- To view, visit https://gerrit.ovirt.org/38358 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95958b4821fa8f55ee8913e926f9528ae56e20e8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
