Martin Peřina has posted comments on this change. Change subject: core: Introduce SingleAgentFenceActionExecutor ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/38358/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java: Line 24: SingleAgentFenceActionExecutor > How is this class different than FenceAgentExecutor which you've added in t There's not a redundancy: 1. FenceAgentExecutor manages execution is simple fence action (on, off, status) on specified fence agent,handles finding proxy using FenceProxyLocator and retries with different/same proxy 2. SingleAgentFenceAction management execution of complex fence action for specified host. By complex I mean that for stop/start we wait for host to reach desired power status and we are using status action. And it also handle retries of start/stop action, retries of status action ... I know that it's a bit confusing, but we have several levels of "fence action" 1. Lower agent level (FenceAgentExecutor) - just plain execution of the action using selected proxy 2. Upper agent level (SingleAgentFenceActionExecutor, ConcurrentAgentsFenceActionExecturo) - execution of start/stop action for selected agent/agents with additional status actions to wait for host to reach desired power status 3. Client level (Start/Stop/RestartVDSCommands) - here we have start, stop, status and restart (calls stop and then start) fence actions. At this level I would call start/stop/restart/status "power management" actions and not "fence" actions -- To view, visit https://gerrit.ovirt.org/38358 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95958b4821fa8f55ee8913e926f9528ae56e20e8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
